Merge pull request #217 from kaczmarczyck/make-up-option

fail on UP=true in make
2020-11-23 13:03:43 +01:00
parent a412da8c73 5bf73cb8fd
commit 0cce91f280
1 changed files with 2 additions and 4 deletions
--- a/src/ctap/data_formats.rs
+++ b/src/ctap/data_formats.rs
@@ -361,11 +361,9 @@ impl TryFrom<cbor::Value> for MakeCredentialOptions {
            Some(options_entry) => extract_bool(options_entry)?,
            None => false,
        };
-        if let Some(options_entry) = up {
-            if !extract_bool(options_entry)? {
+        if up.is_some() {
            return Err(Ctap2StatusCode::CTAP2_ERR_INVALID_OPTION);
        }
-        }
        let uv = match uv {
            Some(options_entry) => extract_bool(options_entry)?,
            None => false,