From 5bf73cb8fdcd4bcb33381992c8608fd77df7dce6 Mon Sep 17 00:00:00 2001
From: Fabian Kaczmarczyck <kaczmarczyck@google.com>
Date: Fri, 20 Nov 2020 03:26:26 +0100
Subject: [PATCH] fail on UP=true in make

---
 src/ctap/data_formats.rs | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/ctap/data_formats.rs b/src/ctap/data_formats.rs
index dacafe5..45ebf9f 100644
--- a/src/ctap/data_formats.rs
+++ b/src/ctap/data_formats.rs
@@ -361,10 +361,8 @@ impl TryFrom<cbor::Value> for MakeCredentialOptions {
             Some(options_entry) => extract_bool(options_entry)?,
             None => false,
         };
-        if let Some(options_entry) = up {
-            if !extract_bool(options_entry)? {
-                return Err(Ctap2StatusCode::CTAP2_ERR_INVALID_OPTION);
-            }
+        if up.is_some() {
+            return Err(Ctap2StatusCode::CTAP2_ERR_INVALID_OPTION);
         }
         let uv = match uv {
             Some(options_entry) => extract_bool(options_entry)?,