Commit Graph

311 Commits

Author SHA1 Message Date
Fabian Kaczmarczyck
90def7dfd3 implicitly generate HMAC-secret 2020-12-08 18:12:48 +01:00
Kamran Khan
56bc86c5d0 No need to cast again 2020-12-07 23:40:06 -08:00
Kamran Khan
2d17bb2afa Readability improvements 2020-12-07 23:38:21 -08:00
Kamran Khan
373464b72d Remove redundant type declaration 2020-12-07 23:35:47 -08:00
Kamran Khan
e4d160aaee Use TryFrom to convert between APDU and CTAP status codes 2020-12-07 23:32:04 -08:00
Kamran Khan
4c84e94039 Use new APDU parser in CTAP1 code 2020-12-07 21:23:55 -08:00
kaczmarczyck
c5007e384e Merge branch 'master' into v2_lib 2020-12-04 15:26:03 +01:00
Fabian Kaczmarczyck
0b55ff3c3a fixes formatting 2020-12-04 14:57:11 +01:00
Julien Cretin
16c0196b1d Check global counter length 2020-12-04 14:42:16 +01:00
Fabian Kaczmarczyck
21b8ad18ce fix clippy warning in apdu 2020-12-04 13:41:56 +01:00
Fabian Kaczmarczyck
b032a15654 makes the global signature counter more privacy friendly 2020-12-04 13:41:41 +01:00
Kamran Khan
1eaff57c88 Le should be interpreted as 0x10000 even in the 2-byte case 2020-12-03 08:25:34 -08:00
Kamran Khan
4bfce88e9b Remove indention level made redundant by early-return 2020-12-03 08:14:07 -08:00
Kamran Khan
bec94f02be Tweak Le appropriately depending on its swize 2020-12-03 08:10:44 -08:00
Kamran Khan
cc8bdb982d Remove unknown apdu type 2020-12-03 07:55:34 -08:00
Kamran Khan
69cdd4a0dc Use (relatively more) appropriate error code) 2020-12-03 07:53:22 -08:00
Kamran Khan
71ec2cf937 Return an error when the case isn't determined 2020-12-03 07:50:05 -08:00
Kamran Khan
943d7af503 Payload does not need to be an array 2020-12-02 23:43:35 -08:00
Kamran Khan
9fc1ac114d Reuse frame bytes for payload 2020-12-02 23:39:48 -08:00
Kamran Khan
524ebe3fce Prevent int overflow by casting before addition 2020-12-02 23:32:25 -08:00
Kamran Khan
1d8c103d9b Construct and return immutable instances of APDU instead of mutating one 2020-12-02 23:29:11 -08:00
Kamran Khan
0420ad8de6 Use constant for consistency 2020-12-02 23:06:24 -08:00
Kamran Khan
2c49718fee Lc3DataLe3 is not a valid case 2020-12-02 23:03:35 -08:00
Kamran Khan
b9ffe7e4ce Use constant instead of hardcoded integer 2020-12-02 23:02:07 -08:00
Kamran Khan
dc95310fc0 Clarify comments 2020-12-01 10:13:25 -08:00
Julien Cretin
042108e3d9 Reserve 700 additional keys for credential-related stuff 2020-12-01 17:46:28 +01:00
Julien Cretin
b55d432043 Apply review comments 2020-12-01 15:39:51 +01:00
Julien Cretin
1db73c699b Apply review comments 2020-12-01 11:29:52 +01:00
Kamran Khan
ce46af0b6b Make cargo fmt happy 2020-11-30 14:43:44 -08:00
Kamran Khan
94f548d5c5 Add extended APDU parser 2020-11-30 14:35:01 -08:00
Kamran Khan
5f5f72b6d1 Use arrayref for converting into ApduHeader 2020-11-30 02:04:52 -08:00
Julien Cretin
7997041be0 Merge branch 'master' into v2_lib 2020-11-30 10:34:54 +01:00
Kamran Khan
d70dd24ffd Merge remote-tracking branch 'upstream/master' into apdu-parser-kk 2020-11-30 00:23:26 -08:00
Julien Cretin
a0801c3023 Merge branch 'master' into v2_lib 2020-11-28 19:27:21 +01:00
Fabian Kaczmarczyck
2a4677c0b1 adds user data to persistent storage 2020-11-27 16:53:12 +01:00
Fabian Kaczmarczyck
1571f58cd3 wrapping_add in storage and more moving 2020-11-26 19:21:41 +01:00
kaczmarczyck
1d7365c4cb Merge branch 'master' into get-next-assertion 2020-11-26 18:51:06 +01:00
Jean-Michel Picod
3d1d827984 Address PR comments 2020-11-26 16:29:14 +01:00
Fabian Kaczmarczyck
3aef7e8b19 reuse update_command_permission 2020-11-26 15:56:59 +01:00
Fabian Kaczmarczyck
ed59ebac0d command timeout for GetNextAssertion 2020-11-26 14:56:52 +01:00
Fabian Kaczmarczyck
ffe19e152b moves UP check in GetAssertion before NO_CREDENTIALS 2020-11-26 14:41:22 +01:00
Fabian Kaczmarczyck
5ff3816782 sets the correct user and number of credentials 2020-11-26 14:41:22 +01:00
Fabian Kaczmarczyck
af4eef8085 adds credential ordering 2020-11-26 14:41:21 +01:00
Fabian Kaczmarczyck
3ae59ce1ec GetNextAssertion command minimal implementation
This still lacks order of credentials and timeouts.
2020-11-26 14:41:21 +01:00
Jean-Michel Picod
d491492554 Format 2020-11-25 17:48:47 +01:00
Jean-Michel Picod
f2b3ca4029 Make private key sensitive and ensure attestation is OTP 2020-11-25 17:44:52 +01:00
Jean-Michel Picod
f47e1e2a86 Ensure store behaves as expected in prod 2020-11-25 17:44:19 +01:00
Jean-Michel Picod
41f7cc7b14 CTAP1/U2F accesses attestation material through the store. 2020-11-25 17:31:05 +01:00
Jean-Michel Picod
026b4a66ac Fix CTAP2 batch attestation 2020-11-25 17:26:08 +01:00
Jean-Michel Picod
3dbfae972f Always insert attestation material in the store 2020-11-25 17:17:57 +01:00