kmwebnet/OpenSK
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

moves UP check in GetAssertion before NO_CREDENTIALS

Browse Source
This commit is contained in:
Fabian Kaczmarczyck
2020-11-24 17:17:18 +01:00
parent 5ff3816782
commit ffe19e152b
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/ctap/mod.rs
View File

@@ -736,15 +736,17 @@ where
} }
credentials.sort_unstable_by_key(|c| c.creation_order); credentials.sort_unstable_by_key(|c| c.creation_order);
// This check comes before CTAP2_ERR_NO_CREDENTIALS in CTAP 2.0.
// For CTAP 2.1, it was moved to a later protocol step.
if options.up {
(self.check_user_presence)(cid)?;
}
let (credential, remaining_credentials) = credentials let (credential, remaining_credentials) = credentials
.split_last() .split_last()
.ok_or(Ctap2StatusCode::CTAP2_ERR_NO_CREDENTIALS)?; .ok_or(Ctap2StatusCode::CTAP2_ERR_NO_CREDENTIALS)?;
self.next_credentials = remaining_credentials.to_vec(); self.next_credentials = remaining_credentials.to_vec();
if options.up {
(self.check_user_presence)(cid)?;
}
self.increment_global_signature_counter()?; self.increment_global_signature_counter()?;
let assertion_input = AssertionInput { let assertion_input = AssertionInput {