Apply review comments

This commit is contained in:
Julien Cretin
2020-12-01 15:39:51 +01:00
parent 1db73c699b
commit b55d432043
2 changed files with 4 additions and 4 deletions

View File

@@ -387,7 +387,8 @@ impl PersistentStore {
Ok(self.store.insert(key::MIN_PIN_LENGTH, &[min_pin_length])?) Ok(self.store.insert(key::MIN_PIN_LENGTH, &[min_pin_length])?)
} }
/// Returns a list of RP IDs that used to check if reading the minimum PIN length is allowed. /// Returns the list of RP IDs that are used to check if reading the minimum PIN length is
/// allowed.
#[cfg(feature = "with_ctap2_1")] #[cfg(feature = "with_ctap2_1")]
pub fn _min_pin_length_rp_ids(&self) -> Result<Vec<String>, Ctap2StatusCode> { pub fn _min_pin_length_rp_ids(&self) -> Result<Vec<String>, Ctap2StatusCode> {
let rp_ids = self let rp_ids = self
@@ -400,7 +401,7 @@ impl PersistentStore {
Ok(rp_ids.unwrap_or(vec![])) Ok(rp_ids.unwrap_or(vec![]))
} }
/// Set a list of RP IDs that used to check if reading the minimum PIN length is allowed. /// Sets the list of RP IDs that are used to check if reading the minimum PIN length is allowed.
#[cfg(feature = "with_ctap2_1")] #[cfg(feature = "with_ctap2_1")]
pub fn _set_min_pin_length_rp_ids( pub fn _set_min_pin_length_rp_ids(
&mut self, &mut self,

View File

@@ -104,8 +104,7 @@ make_partition! {
/// The encryption and hmac keys. /// The encryption and hmac keys.
/// ///
/// This entry is always present. It is generated at startup if absent. This is not a persistent /// This entry is always present. It is generated at startup if absent.
/// key because its value should change after a CTAP reset.
MASTER_KEYS = 2046; MASTER_KEYS = 2046;
/// The global signature counter. /// The global signature counter.