kmwebnet/OpenSK
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #479 from ia0/no_eq

Browse Source 
Only derive PartialEq and Eq for PrivateKey for tests
This commit is contained in:
Julien Cretin
2022-05-17 23:48:24 +02:00
committed by GitHub
parent f95ae1f5ab 07424c3123
commit 6f40c9ad48
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/ctap/crypto_wrapper.rs
View File

@@ -89,7 +89,9 @@ pub fn aes256_cbc_decrypt(
} }
/// An asymmetric private key that can sign messages. /// An asymmetric private key that can sign messages.
#[derive(Clone, Debug, PartialEq, Eq)] #[derive(Clone, Debug)]
// We shouldn't compare private keys in prod without constant-time operations.
#[cfg_attr(test, derive(PartialEq, Eq))]
pub enum PrivateKey { pub enum PrivateKey {
Ecdsa(ecdsa::SecKey), Ecdsa(ecdsa::SecKey),
} }

3
src/ctap/data_formats.rs
View File

@@ -571,7 +571,8 @@ impl TryFrom<cbor::Value> for CredentialProtectionPolicy {
// //
// Note that we only use the WebAuthn definition as an example. This data-structure is not specified // Note that we only use the WebAuthn definition as an example. This data-structure is not specified
// by FIDO. In particular we may choose how we serialize and deserialize it. // by FIDO. In particular we may choose how we serialize and deserialize it.
#[derive(Clone, Debug, PartialEq, Eq)] #[derive(Clone, Debug)]
#[cfg_attr(test, derive(PartialEq, Eq))]
pub struct PublicKeyCredentialSource { pub struct PublicKeyCredentialSource {
pub key_type: PublicKeyCredentialType, pub key_type: PublicKeyCredentialType,
pub credential_id: Vec<u8>, pub credential_id: Vec<u8>,