Apply review comments

2020-12-01 11:29:52 +01:00
parent 069a1b8f19
commit 1db73c699b
3 changed files with 20 additions and 16 deletions
--- a/src/ctap/storage/key.rs
+++ b/src/ctap/storage/key.rs
@@ -82,10 +82,13 @@ make_partition! {
    /// board may configure `MAX_SUPPORTED_RESIDENTIAL_KEYS` depending on the storage size.
    CREDENTIALS = 1700..2000;

-    /// TODO: Help from reviewer needed for documentation.
+    /// List of RP IDs allowed to read the minimum PIN length.
+    #[cfg(feature = "with_ctap2_1")]
    _MIN_PIN_LENGTH_RP_IDS = 2042;

    /// The minimum PIN length.
+    ///
+    /// If the entry is absent, the minimum PIN length is `DEFAULT_MIN_PIN_LENGTH`.
    #[cfg(feature = "with_ctap2_1")]
    MIN_PIN_LENGTH = 2043;