Check global counter length

2020-12-04 14:42:16 +01:00
parent 042108e3d9
commit 16c0196b1d
1 changed files with 5 additions and 4 deletions
--- a/src/ctap/storage.rs
+++ b/src/ctap/storage.rs
@@ -294,10 +294,11 @@ impl PersistentStore {

    /// Returns the global signature counter.
    pub fn global_signature_counter(&self) -> Result<u32, Ctap2StatusCode> {
-        Ok(match self.store.find(key::GLOBAL_SIGNATURE_COUNTER)? {
-            None => 0,
-            Some(value) => u32::from_ne_bytes(*array_ref!(&value, 0, 4)),
-        })
+        match self.store.find(key::GLOBAL_SIGNATURE_COUNTER)? {
+            None => Ok(0),
+            Some(value) if value.len() == 4 => Ok(u32::from_ne_bytes(*array_ref!(&value, 0, 4))),
+            Some(_) => Err(Ctap2StatusCode::CTAP2_ERR_VENDOR_INVALID_PERSISTENT_STORAGE),
+        }
    }

    /// Increments the global signature counter.